[Patch Fix] Support arbitrary symmetric allocations and fix MFC time log in workers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrett4wade
changed the title
nuzant
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
Patch Fixes
Increase the default timeout of NCCL process groups to 1800 secs. Transferring extremely large batches for the first time may consumer over 600 secs, which is the default timeout of pytorch.
Offload models upon initialization to save the memory for the first MFC.
A more accurate record of the MFC completion time. The model worker will return responses immediately to the master worker upon an MFC's completion.
Modify the naming of helper functions in the master worker to avoid confusion.