Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KITTI-3D importer and exporter #1596

Merged
merged 6 commits into from
Sep 2, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Sep 2, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners September 2, 2024 01:59
@wonjuleee wonjuleee requested review from jihyeonyi and removed request for a team September 2, 2024 01:59
Copy link

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (releases/1.9.0@0cbcd58). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...atumaro/plugins/data_formats/kitti_raw/exporter.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.9.0    #1596   +/-   ##
=================================================
  Coverage                  ?   81.06%           
=================================================
  Files                     ?      278           
  Lines                     ?    32517           
  Branches                  ?     6607           
=================================================
  Hits                      ?    26360           
  Misses                    ?     4701           
  Partials                  ?     1456           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.05% <50.00%> (?)
windows-2022_Python-3.10 81.04% <50.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit 51c316a into openvinotoolkit:releases/1.9.0 Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants