Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove yurt-coordinator from yurthub #2276

Merged

Conversation

rambohe-ch
Copy link
Member

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind bug
/kind documentation
/kind enhancement
/kind good-first-issue
/kind feature
/kind question
/kind design
/sig ai
/sig iot
/sig network
/sig storage

/kind feature

What this PR does / why we need it:

remove the code related to yurt-coordinator in Yurthub component.

Which issue(s) this PR fixes:

Fixes #2257

Special notes for your reviewer:

Does this PR introduce a user-facing change?


other Note

@rambohe-ch rambohe-ch requested a review from a team as a code owner January 24, 2025 13:26
@rambohe-ch
Copy link
Member Author

@YTGhost PTAL

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.

Project coverage is 46.10%. Comparing base (a382ab9) to head (59e16d0).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/yurthub/proxy/proxy.go 0.00% 16 Missing ⚠️
pkg/yurthub/proxy/remote/loadbalancer.go 0.00% 4 Missing ⚠️
cmd/yurthub/app/start.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
+ Coverage   45.36%   46.10%   +0.73%     
==========================================
  Files         427      415      -12     
  Lines       29105    27186    -1919     
==========================================
- Hits        13204    12533     -671     
+ Misses      14586    13383    -1203     
+ Partials     1315     1270      -45     
Flag Coverage Δ
unittests 46.10% <38.23%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rambohe-ch rambohe-ch force-pushed the remove-yurt-coordinator-from-yurthub branch from 6ae6673 to 59e16d0 Compare January 24, 2025 13:34
Copy link
Member

@YTGhost YTGhost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YTGhost YTGhost merged commit 219300f into openyurtio:master Jan 24, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]remove yurt-coordinator adaption code from yurthub component
2 participants