-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature view engine rebased #391
Open
matthieucan
wants to merge
31
commits into
opinkerfi:master
Choose a base branch
from
matthieucan:feature-view-engine-rebased
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature view engine rebased #391
matthieucan
wants to merge
31
commits into
opinkerfi:master
from
matthieucan:feature-view-engine-rebased
+17,595
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The files contained in status/custom_*.py and status/templates/custom_* pemit to have a views engine, i.e. a customised form in where you can choose the data you need from Livestatus datasources/columns, arrange them how you like (sorting, filtering, stats) and feed this data to pre-defined templates or your own ones. The views can be represented with simple dictionaries, and are therefore stored through the userdata module. User-defined customised views are now possible within Adagios :)
* datatable: jquery plugin to render html tables into pageable/sortable/filterable tables. Simpler and more functional than datatables. * jquery-ui: contains the functions which permit DOM elements to me draggable. This is used in custom forms, where the user can re-order the colums, filters, etc.
This templates, through the help of jqplot, can display a pie chart representing data coming from aggregated Livestatus queries (with the "Stats:" clause).
Through OpenLayers.js, displays a map with red/green markers representing the state of all defined hosts. The IP addresses are mapped to GPS coordianates through GeoIP.
This patch fixes an issue where custom_view cannot be loaded because an extra linebreak is sent with the livestatus query. I am guessing shinken's implementation of livestatus does not care about this.
If livestatus queries fail, return 500 error This should make unit testing of the view easier.
This is cool for wall projection (and for the future dashboard. Conflicts: adagios/status/templates/custom_views/templates/maps.html
The 'delete view' button is now on the edit page, rather than the view page.
Conflicts: adagios/templates/base.html
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request following reviews from #383