Replace OreSatId with Consts #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThirteenFish
force-pushed
the
clean-oresat-configs
branch
from
1c4e1a2 to
ae58fcb
Compare
As with the other similar changes, this uses Mission.default() for mission selection as OreSatId is has been removed. Also fixed up the CI warning for out-of-date actions.
ThirteenFish
force-pushed
the
clean-oresat-configs
branch
from
ae58fcb to
6bb2f11
Compare
|
This will either need to wait for a new release of |
A recent oresat-configs patch changed class Card from which Node is subclassed. Cardd now has a few non-init fields and a field that is init-only so Node needs to be constructed with explicit args now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As with the other similar changes, this uses Mission.default() for mission selection as OreSatId has been removed.
Also fixed up the CI a bit, stopped warnings for out-of-date actions.