Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make OIDC remove button loading state specific #339

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

@jonas-jonas jonas-jonas self-assigned this Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.

Project coverage is 42.25%. Comparing base (f3fad4d) to head (432d461).
Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   42.43%   42.25%   -0.18%     
==========================================
  Files         136      138       +2     
  Lines        2008     2104      +96     
  Branches      288      312      +24     
==========================================
+ Hits          852      889      +37     
- Misses       1149     1203      +54     
- Partials        7       12       +5     
Components Coverage Δ
@ory/elements-react 37.05% <32.17%> (+0.26%) ⬆️
@ory/nextjs 64.33% <74.24%> (-1.65%) ⬇️

@jonas-jonas jonas-jonas merged commit b17786c into main Jan 24, 2025
14 of 15 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/fixTrashIconLoading branch January 24, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant