-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract prepare_wsl
to the Windows instalation testsuite
#20976
base: master
Are you sure you want to change the base?
Extract prepare_wsl
to the Windows instalation testsuite
#20976
Conversation
5de0a99
to
c9316b7
Compare
dc98b8a
to
0b2e54f
Compare
Please do aarch64 test runs as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is get_var("WSL2")
in prepare_wsl.pm, which means that the generated image is WSL version specific. If that's true, that's annoying to deal with (twice as many images needed). If it's not true, then the condition should be removed.
We were thinking of generating two different images for WSL1 and WSL2, but then we realised that enabling WSL1 was just a single command and it doesn't seem worthy. |
Sounds good, so the get_var could be removed? For aarch64 it'll be annoying to deal with though because WSL2 needs software emulation, which means the installation will take a few hours and it might no longer boot on KVM hosts (needs to be tested). |
Right now, the module
prepare_wsl
and part ofinstall_wsl
is being run in every single WSL test suite.The idea is to extract it to the 'Windows installation' test suite, so that the
qcow2
image created is ready to be used.