Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract prepare_wsl to the Windows instalation testsuite #20976

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pablo-herranz
Copy link
Contributor

@pablo-herranz pablo-herranz commented Jan 16, 2025

Right now, the module prepare_wsl and part of install_wsl is being run in every single WSL test suite.

The idea is to extract it to the 'Windows installation' test suite, so that the qcow2 image created is ready to be used.

@pablo-herranz pablo-herranz force-pushed the poo175614_extract-preparewsl-from-all-testsuites branch 3 times, most recently from 5de0a99 to c9316b7 Compare January 17, 2025 09:31
@pablo-herranz pablo-herranz marked this pull request as ready for review January 20, 2025 08:39
@pablo-herranz pablo-herranz force-pushed the poo175614_extract-preparewsl-from-all-testsuites branch from dc98b8a to 0b2e54f Compare January 20, 2025 08:41
@Vogtinator
Copy link
Member

Please do aarch64 test runs as well.

Copy link
Member

@Vogtinator Vogtinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is get_var("WSL2") in prepare_wsl.pm, which means that the generated image is WSL version specific. If that's true, that's annoying to deal with (twice as many images needed). If it's not true, then the condition should be removed.

@pablo-herranz
Copy link
Contributor Author

pablo-herranz commented Jan 20, 2025

There is get_var("WSL2") in prepare_wsl.pm, which means that the generated image is WSL version specific. If that's true, that's annoying to deal with (twice as many images needed). If it's not true, then the condition should be removed.

We were thinking of generating two different images for WSL1 and WSL2, but then we realised that enabling WSL1 was just a single command and it doesn't seem worthy.

@Vogtinator
Copy link
Member

There is get_var("WSL2") in prepare_wsl.pm, which means that the generated image is WSL version specific. If that's true, that's annoying to deal with (twice as many images needed). If it's not true, then the condition should be removed.

We were thinking of generating two different images for WSL1 and WSL2, but then we realised that enabling WSL1 was just a single command and it doesn't seem worthy.

Sounds good, so the get_var could be removed?

For aarch64 it'll be annoying to deal with though because WSL2 needs software emulation, which means the installation will take a few hours and it might no longer boot on KVM hosts (needs to be tested).

@pablo-herranz pablo-herranz marked this pull request as draft January 20, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants