New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch `bun -` & alert/prompt/confirm to use `bun.Output.buffered_stdin` #16554

Open

pfgithub wants to merge 2 commits into main from pfg/switch-stdin-to-bun-file

+126 −7

Contributor

pfgithub commented Jan 20, 2025 •

edited

Loading

What does this PR do?

std.io.getStdIn().reader() -> bun.Output.buffered_stdin.reader() + adds tests for alert/prompt/confirm

This also fixes a bug where await $`echo y | bun --print "confirm()"`; would return false instead of true

pfgithub added 2 commits

January 20, 2025 14:30


          read stdin from bun.sys.File

1275dc0


          switch to bun.Output.buffered_stdin and add more tests for alert/prom…

4ea7504

…pt/confirm

robobun commented Jan 20, 2025 •

edited

Loading

^{Updated 5:39 PM PT - Jan 20th, 2025}

❌ @pfgithub, your commit 4ea7504 has 4 failures in #10180:

test/js/node/test/parallel/test-stdin-script-child-option.js - code 1 on 🪟 2019 x64
test/js/node/test/parallel/test-stdin-script-child-option.js - code 1 on 🪟 2019 x64-baseline
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 14 aarch64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 13 aarch64
test/cli/install/bun-run.test.ts - 1 failing on 🪟 2019 x64
test/cli/install/bun-run.test.ts - 1 failing on 🪟 2019 x64-baseline
test/cli/run/run-eval.test.ts - 8 failing on 🪟 2019 x64
test/cli/run/run-eval.test.ts - 8 failing on 🪟 2019 x64-baseline

🧪 try this PR locally:

bunx bun-pr 16554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet