Add bruteforce prevention in wallet changepassword function #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syjn99
reviewed
Jan 15, 2025
Comment on lines
+1056
to
+1059
| req = httptest.NewRequest(http.MethodPost, "/v2/validator/wallet/change-password", &buf) | ||
| wr = httptest.NewRecorder() | ||
| wr.Body = &bytes.Buffer{} | ||
| s.ChangePassword(wr, req) |
There was a problem hiding this comment.
Wonder why this test requests /v2/validator/wallet/change-password twice
There was a problem hiding this comment.
The first attempt triggers the lockout and the second attempt checks if lockout is properly performed. I should have added comments about this.
validator/rpc/handler_wallet_test.go
Outdated
| require.Equal(t, http.StatusBadRequest, wr.Code) | ||
| require.StringContains(t, "Old password is not correct", wr.Body.String()) | ||
| } else { | ||
| // On the final attempt, we expect the server to lock out the user (429 or similar). |
There was a problem hiding this comment.
Current implementation doesn't return 429 code, so this comment might be misleading.
validator/rpc/handler_wallet_test.go
Outdated
| wr.Body = &bytes.Buffer{} | ||
| s.ChangePassword(wr, req) | ||
|
|
||
| // Expect locked-out response (429 or 400 with a lockout message). |
validator/rpc/handler_wallet_test.go
Outdated
| wrongPassword := "wrong-old-password" | ||
| encryptedWrongPassword, err := aes.Encrypt(cipher, []byte(wrongPassword)) | ||
| require.NoError(t, err) | ||
| encryptedNewPassword, err := aes.Encrypt(cipher, []byte("newValidPassword")) |
There was a problem hiding this comment.
Suggested change
| encryptedNewPassword, err := aes.Encrypt(cipher, []byte("newValidPassword")) | |
| newValidPassword := "new-valid-password" | |
| encryptedNewPassword, err := aes.Encrypt(cipher, []byte(newValidPassword)) |
validator/rpc/handler_wallet_test.go
Outdated
| // 2. Provide correct old password but an obviously too-short new password | ||
| encryptedOldPassword, err := aes.Encrypt(cipher, []byte(oldPassword)) | ||
| require.NoError(t, err) | ||
| encryptedShortPassword, err := aes.Encrypt(cipher, []byte("12")) // fails ValidatePasswordInput? |
There was a problem hiding this comment.
As minPasswordLength is 8, how about explictly define a shortPassword whose length is less than 8?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add bruteforce prevention in
validator/rpc/handler_wallet.ChangePassword.