Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests/Unit/js to tests/js #713

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Move tests/Unit/js to tests/js #713

merged 2 commits into from
Mar 5, 2019

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Mar 3, 2019

To be consistent with all other apps that put the js tests in tests/js
e.g. guests customgroups files_lifecycle user_management

activity is the only app that I found that put the js tests under tests/Unit/js

This will help with owncloud/QA#604 by having the location of js tests consistent across apps.

  1. Move the js tests up into tests/js
  2. Move package.son up to the root dir, and adjust the test-js rules in Makefile to be similar to what is done in other apps.

@phil-davis phil-davis self-assigned this Mar 3, 2019
@phil-davis phil-davis requested a review from PVince81 March 3, 2019 13:15
@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #713   +/-   ##
========================================
  Coverage      83.9%   83.9%           
  Complexity      502     502           
========================================
  Files            45      45           
  Lines          1802    1802           
========================================
  Hits           1512    1512           
  Misses          290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb63afc...3609b35. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #713 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #713   +/-   ##
========================================
  Coverage      83.9%   83.9%           
  Complexity      502     502           
========================================
  Files            45      45           
  Lines          1802    1802           
========================================
  Hits           1512    1512           
  Misses          290     290

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062988c...d68d5ac. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 136afa9 into master Mar 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the move-tests-js branch March 5, 2019 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants