Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] Rename make test-php to test-php-unit #34640

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

phil-davis
Copy link
Contributor

Backport #34638

@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34640 into stable10 will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34640      +/-   ##
==============================================
- Coverage       63.98%   63.98%   -0.01%     
  Complexity      19227    19227              
==============================================
  Files            1272     1272              
  Lines           75724    75724              
  Branches         1291     1291              
==============================================
- Hits            48454    48453       -1     
- Misses          26891    26892       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.13% <ø> (-0.01%) 19227 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/private/Server.php 84.75% <0%> (-0.14%) 129% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e34bd6...a18456b. Read the comment docs.

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 3974d9c into stable10 Feb 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-test-php-unit branch February 28, 2019 11:21
@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants