Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Add more test coverage to apiCustomGroups #427

Merged
merged 1 commit into from
May 28, 2021

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented May 25, 2021

This PR adds more test coverage to apiCustomGroups
part of : #425

@CLAassistant
Copy link

CLAassistant commented May 25, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@dpakach dpakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@SwikritiT SwikritiT force-pushed the add-test-coverage branch from 0110c83 to b2b3721 Compare May 26, 2021 06:10
@SwikritiT SwikritiT requested a review from phil-davis May 26, 2021 06:11
Copy link

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be better if you fix these spacing

And the HTTP status code should be "200"
And as "Brian" folder "/sub-folder" should exist

Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group
Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group

And the HTTP status code should be "200"
And as "Carol" folder "/sub-folder" should exist

Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group
Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group

@SwikritiT SwikritiT force-pushed the add-test-coverage branch from b2b3721 to 8e7cab0 Compare May 28, 2021 07:42
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 47b18ee into master May 28, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-test-coverage branch May 28, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants