-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Add more test coverage to apiCustomGroups #427
Conversation
8940e1a
to
e809dc8
Compare
tests/acceptance/features/apiCustomGroups/sharingCustomGroups.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/apiCustomGroups/sharingCustomGroups.feature
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍🏼
0110c83
to
b2b3721
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it would be better if you fix these spacing
And the HTTP status code should be "200" | ||
And as "Brian" folder "/sub-folder" should exist | ||
|
||
Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group | |
Scenario: sharing sub-folder to a normal group when the main folder is already shared with a custom group |
And the HTTP status code should be "200" | ||
And as "Carol" folder "/sub-folder" should exist | ||
|
||
Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group | |
Scenario: sharing sub-folder to a custom group when the main folder is already shared with a normal group |
b2b3721
to
8e7cab0
Compare
Kudos, SonarCloud Quality Gate passed! |
This PR adds more test coverage to apiCustomGroups
part of : #425