fix(ui): remove stale thumbnails in bulkUpload after partial success #10651
+27
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes an issue in the
BulkUploadcomponent (namely theFormsManager), where partial successes on saving images causes subsequent images to show a stale thumbnail of the previous image.Why?
To properly expel successful image thumbnails after their thumbnails are no longer relevant to the workflow.
How?
By removing those images from the thumbnails references in
FormsManager.Fixes #10650
Before:
Editing---Post-before--Payload.webm
After:
Editing---Post-after--Payload.webm
Notes:
BulkUploadwhere if an image has validation errors, say for example analtfield was left empty, then you type really quickly and hit save before the validation error in the ui disappears, that the image will in fact upload but the form will still assume there is an error. This means one could continuously upload the same image.