Patch 1 #4
Open
Patch 1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your code seems alright, however check out this doc https://docs.google.com/spreadsheets/d/1lPY1fnPtlCkGDwcxQpC7W9dZVVhDgysbBPSDziLbTGY/edit?usp=sharing FPTP was already selected by another team, and they made a PR #2 before you as well. Along with that, you didn't fill the doc. Try to implement another mechanism till 18th midnight if you can. Along with that, follow the recommended directory structure. (Voting/mechanism_name) |
|
I have updated google docs. I also added Two round voting system. I am new to GitHub I was unable to understand the "recommended directory structure" part. I tried to correct it to. Tell me if further changes are required! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Saket Dhakar, Anshit Arya and Prashant Verma have worked on FPTP voting system