Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkp/pkp-lib#6251 Add isPreprintOf relation to DOI exports #10

Merged
merged 2 commits into from
Jun 20, 2022

Conversation

ajnyga
Copy link
Contributor

@ajnyga ajnyga commented Feb 26, 2022

@ajnyga
Copy link
Contributor Author

ajnyga commented Feb 26, 2022

@ewhanson @NateWr

This is an additional change to the OPS Crossref plugin to introduce isPreprintOf relation (link to the version of record DOI).

There is an older pr for this, but it was delayed because of the ongoing DOI work. See the discussion here where Nate suggest how the OPS DOI plugin should force versioning of DOIs if Crossref is used for registering: https://github.com/pkp/ops/pull/103/files. However, now I've just heard from Alex that this could change. But that is probably something that still needs to be resolved.

In any case this should be merged first, I can rebase this pr after that if needed: #9

Copy link
Contributor

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just the one change to code organisation.

filter/PreprintCrossrefXmlFilter.inc.php Outdated Show resolved Hide resolved
@ajnyga
Copy link
Contributor Author

ajnyga commented May 22, 2022

@NateWr split the function to two parts as requested.

Since #9 is touching the same code, I will wait for this to be merged first.

@NateWr
Copy link
Contributor

NateWr commented May 26, 2022

Looks good. Are there any other pull requests that need to be merged simultaneously with this one?

@ajnyga
Copy link
Contributor Author

ajnyga commented Jun 13, 2022

hmm, why did I not see an alert about this...

There is another one, but it would be easier if this would be merged first and I could rebase the other and pr it then.

@NateWr NateWr merged commit 411e2aa into pkp:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants