-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line search #1208
Closed
+1,012
−4
Closed
Line search #1208
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
383a2f0
BUG: Improve Heaviside implementation
IvarStefansson 23bf2ca
FEAT: Add line search functionality
IvarStefansson 34ff3f1
BUG: Wrong method name.
IvarStefansson 36d852b
TUT: Add tutorial on solution strategies
IvarStefansson 105cd4f
TUT: Simplify line search tutorial
IvarStefansson 72929ea
BUG: Remnants from code migration
IvarStefansson ac58cfe
DOC: Formatting and minor improvements
IvarStefansson aa38a94
STY: flake8
IvarStefansson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of (almost) duplication of governing equations here. I suppose you have considered a refactoring of the relevant parts of
momentum_balance.py
? I would not be surprised if the code is only similar, but not the same..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are quite right. This was part of the motivation for the attempted refactor of the equations three months ago. We did not succeed at the time. I'm very open to a discussion on this, though.