-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1216 benchmark #1261
1216 benchmark #1261
Conversation
@IvarStefansson we called the new runscript |
I removed the link to #1216 since that topic is bigger than what is covered in this PR |
I will have a more thorough look at this, including running the benchmark, but it will not be before second half of next week. |
The benchmark was specified in terms of Dirichlet conditions on the left and right boundaries. Updated type and values accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments based on my reading of the code. It is clear that this wlil be an iterative effort, but let's make sure we have a reasonable starting point before letting this loose into the wild.
My attempt at viewing the results in a browser failed, so I'll need to ask for some assistance at some point.
@keileg about viewing the results in the browser, I can't say that this solution is the most robust - sometimes it just fails with an error. What works for me is to reload the page until it works, it usually take 2-5 reloads. The usual time to "open" the data for me is not more than 10 seconds. I checked in Chrome and Brave. |
@Yuriyzabegaev and @keileg: I haven't experienced any issues with the results not loading in Firefox so far. Perhaps you can try that and see if it works more reliable for you. |
Do you mean run_profiling.py? And I don't know about the placement without some more context/discussion. |
Regarding placement of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the effort
Proposed changes
This adds a
run_profiler
script, which profiles a selected benchmark withviztracer
and displays the results. This is a first implementation of such a feature and open to changes in the future. The plan is that people can try it out in the coming weeks and at some point we update based on our findings of what is actually needed in practice. Adresses #1216.In addition, this adds a new benchmark case with 64 fractures based on this article.
Code written by @Yuriyzabegaev and me.
Types of changes
Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.