Optimizing test exectution for test geometry

[isakhammer]

Proposed changes

Based on issue #1303, we optimized the test to go from 13s to 6s, using @fixture for geometry. In this way we only constructed the object once instead of for every test.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

• Minor change (e.g., dependency bumps, broken links).
• Bugfix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).
• Testing (contribution related to testing of existing or new functionality).
• Documentation (contribution related to adding, improving, or fixing documentation).
• Maintenance (e.g., improve logic and performance, remove obsolete code).
• Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

• The documentation is up-to-date.
• Static typing is included in the update.
• This PR does not duplicate existing functionality.
• The update is covered by the test suite (including tests added in the PR).
• If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

[keileg]

@isakhammer @jwboth I suggest a further refactoring that lead to much easier method signatures, see the latest push. If you agree with this, after possible changes first, I suggest @IvarStefansson has a final look at the PR.

FYI: The tests fail, likely due to some installation issue external to this PR. I'll have a look.

[jwboth]

@keileg I like the approach. Indeed the signatures are much cleaner.

[keileg]

@IvarStefansson Could you to have a look, please?

[IvarStefansson]

I like the solution. Note that I have not reviewed the details, assuming that the tests themselves have not changed even if the diff covers most of the file.

[keileg]

Note that I have not reviewed the details, assuming that the tests themselves have not changed even if the diff covers most of the file.

Correct, beyond simplified method signatures and some referrals to self.geometries, the only change is that pretty much the entire file has had its indentation increased.

[IvarStefansson]

Note that I have not reviewed the details, assuming that the tests themselves have not changed even if the diff covers most of the file.

Correct, beyond simplified method signatures and some referrals to self.geometries, the only change is that pretty much the entire file has had its indentation increased.

Good. Approving.