Fix Windows build with latest msys2 packages #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why the svg pixbuf loader file name changed, but it's easy to fix. For `lib/p11-kit`, it looks like the `mingw-w64-i686-ca-certificates` package has that file. But Keyboard Configurator doesn't seem to really need that, so just remove it.
leviport
approved these changes
Jan 14, 2025
mmstick
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure why the svg pixbuf loader file name changed, but it's easy to fix.
For
lib/p11-kit, it looks like themingw-w64-i686-ca-certificatespackage has that file. But Keyboard Configurator doesn't seem to really need that, so just remove it.(
nobleCI was also failing, but is fixed by pop-os/at-spi2-core#2.)