fix legend of investment marker #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue that I introduced in #4298 sorry.
The non hidden tooltip itself was indeed fixed, but the common excluded label should have been
PortfolioTransaction.Type.BUY.toString()instead ofMessages.SecurityMenuBuy, as this label is used not only as the hidden tooltip, but also as the legend : so nowMessages.SecurityMenuBuyis shown in the legend while it wasPortfolioTransaction.Type.BUY.toString()beforehand; so in French we now have "Acheter" the verb (="to buy") instead of "Achat" the noun (="purchase"), same for sell.With this PR : the tooltip stays hidden for all languages, and the legend reverts to the original
PortfolioTransaction.Type.BUY.toString()label.For French, having the noun in the legend is better. I believe in Dutch and Polish, Aankoop and Kupno are also the noun rather than the verb, so I think it makes sense also for them.