feat: add throttle and delay to connect #478
Open
+164
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 769b46f The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@stevensJourney this is ready for review |
packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts
Show resolved
Hide resolved
DominicGBauer
force-pushed
the
feat/add-throttle-and-delay-to-connect
branch
from
12b6560 to
769b46f
Compare
| connector: PowerSyncBackendConnector, | ||
| // This is used to pass in options on connection instead of only during database creation | ||
| options?: { | ||
| retryDelayMs: number; |
There was a problem hiding this comment.
This could use AdditionalConnectionOptions
| * Delay for retrying sync streaming operations | ||
| * from the PowerSync backend after an error occurs. | ||
| */ | ||
| retryDelay?: number; |
There was a problem hiding this comment.
It's very unfortunate, but I think renaming this to retryDelayMs is a breaking change. We might be able to work around it, but we should keep the old field for consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
retryDelayMsandcrudUploadThrottleMstoconnectso that the values can be dynamically changed on reconnecting.Testing
I ran the todolist demo and confirmed that the values used are from the connect method.