fix: ios app failing on launch #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkistner
approved these changes
Oct 16, 2024
stevensJourney
approved these changes
Oct 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
iOS application was failing on app launch with
powersync-sqlite-core0.3.0+. This was due tointernalDb.get("SELECT powersync_init()")running and resulting in this error being thrownSqlite operation failure powersync_init | error code SQLITE_READONLY. It is still unclear exactly why thegetwould result in an error given it is aSELECTstatement with the error only appearing on iOS and not Android and will require further investigation. However, using sqldelight generated queries has resolved the issue.Work Done
getquery with sqldelight generated queryhasSyncedto true whenlastSyncedis changed as it currently stays false after adisconnectAndClearTesting
Verified this fixes ios app launch failure and that hasSynced changes correctly after a disconnectAndClear