forked from simolus3/sqlite3.dart
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream sqlite3
package, update powersync core to 0.3.9
#19
Open
simolus3
wants to merge
82
commits into
main
Choose a base branch
from
feat/update-upstream-sqlite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-workers `sqlite3_web`: Support opening databases without workers
Added commit / rollback hooks
…er-errors `sqlite3_web`: Fix handling worker errors
We set them to null when closing databases, and crashing if the methods are unavailable (which they are on older WebAssembly modules) is terrible.
Avoiding a late final field weirdly seems to fix the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most notable change from upstream is support for commit / rollback hooks. This also affects the web build slightly since we need to add new bridging functions to Dart.
There's another minor change to the sqlite3 multiple ciphers build, but we're not using that at the moment.