Feat: Full text search and update wa-sqlite #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass 64-bit arguments to javascript with Emscripten legalization.
Export all SQLite3 API functions, plus Emscripten utilities.
Update follow-redirects per Dependabot.
Fix rhashimoto#143. Handle detached buffers in IDBBatchAtomicVFS.
Fix rhashimoto#143 for Safari (no ArrayBuffer.prototype.detached)
Remove prepack build
It is better to use `[]` for object access in Javascript code that is processed by Emscripten. The Javascript libraries passed to emcc are being minified with Google's [Closure Compiler](https://developers.google.com/closure/compiler) due to the `--closure 1` parameter. The closure compiler minifies keys on objects. ```js const mxPathName = vfs.mxPathName ?? 64; ``` is minified as ```js var n=h.Lg??64; ``` where `h.Lg` is undefined, so `n` will always be `64`. With this change, the minified output is ```js var n=h.mxPathName??64; ```
…-changes Rebuild on changes to Javascript libraries
…n-with-mangled-names Bugfix: Avoid dot notation in minified Javascript
Dependabot recommended updates
Comment out FTS build
stevensJourney
previously approved these changes
Apr 17, 2024
mugikhan
changed the title
stevensJourney
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work Done
Update MakeFile with Full Text Search (FTS5) targets.
Update shell script for building fts targets
Update README.md
Update from upstream wa-sqlite