add test coverage for json unmarshal

prebid · Jan 23, 2025 · 4fefda1 · 4fefda1
1 parent 7c0f3cf
commit 4fefda1
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 2 deletions.
diff --git a/adapters/smoot/smoot.go b/adapters/smoot/smoot.go
@@ -80,7 +80,7 @@ func (a *adapter) MakeRequests(request *openrtb2.BidRequest, reqInfo *adapters.E
 		adapterRequests = append(adapterRequests, adapterReq)
 	}
 
-	return adapterRequests, nil
+	return adapterRequests, errs
 }
 
 func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestData, error) {
@@ -93,7 +93,7 @@ func (a *adapter) makeRequest(request *openrtb2.BidRequest) (*adapters.RequestDa
 	headers.Add("Content-Type", "application/json;charset=utf-8")
 	headers.Add("Accept", "application/json")
 	return &adapters.RequestData{
-		Method:  "POST",
+		Method:  http.MethodPost,
 		Uri:     a.endpoint,
 		Body:    reqJSON,
 		Headers: headers,

diff --git a/...ot/smoottest/exemplary/simple-banner.json → ...moottest/exemplary/simple-app-banner.json b/...ot/smoottest/exemplary/simple-banner.json → ...moottest/exemplary/simple-app-banner.json
diff --git a/adapters/smoot/smoottest/supplemental/invalid-bidder.json b/adapters/smoot/smoottest/supplemental/invalid-bidder.json
@@ -0,0 +1,19 @@
+{
+  "mockBidRequest": {
+    "id": "test-request-id",
+    "imp": [
+      {
+        "id": "test-imp-id",
+        "ext": {
+          "bidder": 999
+        }
+      }
+    ]
+  },
+  "expectedMakeRequestsErrors": [
+    {
+      "value": "expect { or n, but found 9",
+      "comparison": "literal"
+    }
+  ]
+}
diff --git a/adapters/smoot/smoottest/supplemental/invalid-ext.json b/adapters/smoot/smoottest/supplemental/invalid-ext.json
@@ -0,0 +1,17 @@
+{
+  "mockBidRequest": {
+    "id": "test-request-id",
+    "imp": [
+      {
+        "id": "test-imp-id",
+        "ext": 123
+      }
+    ]
+  },
+  "expectedMakeRequestsErrors": [
+    {
+      "value": "expect { or n, but found 1",
+      "comparison": "literal"
+    }
+  ]
+}