-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Bidder: TradPlus #5794
base: master
Are you sure you want to change the base?
New Bidder: TradPlus #5794
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Actually, looking at the code here, I think there's a problem. This documentation says We need to talk about what zoneId actually is because it's part of the endpoint domain (https://{{ZoneID}}adx.tradplusad.com/{{AccountID}}/pserver) It's a strict rule in Prebid Server that publishers cannot be made to supply geographic information. It's ok if 'zoneId' is some kind of inventory identifier, but it's not ok if 'zone' is like 'Europe'. If so, zone needs to be optional and the bid adapter code needs to be updated to have a default. |
@bretg Thanks for your question. We have adjusted zoneId to be optional prebid/prebid-server-java#3680. Regarding the value transmission of ZoneID, we confirm that we will not transmit related geographic information; it will only be used as an inventory identifier. |
@bretg hi,the json schema has been updated. |
🏷 Type of documentation
📋 Checklist
New Adapter: TradPlus prebid-server#3987