Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveIntent Rtd Provider: add doc #5795

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

wi101
Copy link
Contributor

@wi101 wi101 commented Jan 9, 2025

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

Copy link

netlify bot commented Jan 9, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 41a1aef
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/678a3100ab3c9d0008e91757
😎 Deploy Preview https://deploy-preview-5795--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wi101 wi101 changed the title update liveintent docs LiveIntent Rtd Provider: add doc Jan 9, 2025

{% include dev-docs/loads-external-javascript.md %}

This module extracts segments from `bidRequest.userId.lipb.segments` enriched by the userID module and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good technical description, but it would be best to start out with a product-oriented description. Why would a business person care about lipb.segments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I updated it

@bretg
Copy link
Contributor

bretg commented Jan 9, 2025

@wi101 - unfortunately, #5797 created a conflict with this PR. Please fix.

@wi101 wi101 requested a review from bretg January 10, 2025 17:22
Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the wording enhancement

@wi101
Copy link
Contributor Author

wi101 commented Jan 17, 2025

@bretg the implementation PR got merged 🎉 could we merge this PR?

@muuki88 muuki88 merged commit e95e09c into prebid:master Jan 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants