[Silabs] Refactor RCP WiFi initialization to remove platform-specific dependencies and unify initialization function #37135
+43
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
rosahay-silabs
changed the title
|
PR #37135: Size comparison from 8370039 to e489f7b Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37135: Size comparison from 8370039 to 43cd521 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
mkardous-silabs
requested changes
Jan 22, 2025
| @@ -646,15 +638,20 @@ void ProcessEvent(WifiPlatformEvent event) | |||
| } | |||
| } | |||
|
|
|||
| void MatterWifiTask(void * arg) | |||
| sl_status_t InitSiWxWifi(void) | |||
There was a problem hiding this comment.
If this function is used by the rs911x WifiInterfaceImpl, the name needs to be updated.
rosahay-silabs
force-pushed
the
feature/realign-wifi-init-rs911x
branch
from
43cd521 to
fdc6069
Compare
|
PR #37135: Size comparison from 22cd392 to fdc6069 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
… and unify initialization function
rosahay-silabs
changed the title
|
PR #37135: Size comparison from 22cd392 to 1fe4ed6 Full report (68 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
Comment on lines
-49
to
-51
| #if (defined(SLI_SI91X_MCU_INTERFACE) && SLI_SI91X_MCU_INTERFACE == 1) | ||
| #include <platform/silabs/SiWx917/SiWxPlatformInterface.h> | ||
| #endif // (defined(SLI_SI91X_MCU_INTERFACE) && SLI_SI91X_MCU_INTERFACE == 1 ) |
There was a problem hiding this comment.
This can't be removed for the time being. Can you re-add it with the same platform todo.
| * SL_STATUS_ALLOCATION_FAILED, if there are a memory allocation failure, | ||
| * SL_STATUS_FAILURE, otherwise | ||
| ******************************************************************************/ | ||
| sl_status_t wfx_bus_start(void); |
There was a problem hiding this comment.
This isn't the correct comment format. We should stop using it entierly.
| * @return None | ||
| ******************************************************************************/ | ||
| void wfx_bus_start() | ||
| sl_status_t wfx_bus_start(void) | ||
| { | ||
| wfx_bus_task_handle = | ||
| xTaskCreateStatic(wfx_bus_task, "wfxbus", BUS_TASK_STACK_SIZE, NULL, WFX_BUS_TASK_PRIORITY, busStack, &busTaskStruct); | ||
| if (wfx_bus_task_handle == NULL) | ||
| { | ||
| SILABS_LOG("*ERR*WFX BusTask"); |
There was a problem hiding this comment.
We are deprecating out the SILABS_LOG macro - please delete it.
Comment on lines
+46
to
+48
| * @return sl_status_t SL_STATUS_OK, if the initialization succeeded | ||
| * SL_STATUS_ALLOCATION_FAILED, if there are a memory allocation failure, | ||
| * SL_STATUS_FAILURE, otherwise |
There was a problem hiding this comment.
This comment isn't exact. We never return SL_STATUS_FAILURE.
| * SL_STATUS_FAILURE, otherwise | ||
| */ | ||
|
|
||
| sl_status_t InitWiFiStack(void); |
There was a problem hiding this comment.
Public APIs in the Wi-Fi interface should always return CHIP_ERROR. The error swap must be done inside the function.
|
|
||
| sl_status_t InitWiFiStack(void) | ||
| { | ||
| // TODO: This function should include sl_wfx_hw_init() and sl_wfx_init() functions. Only done now to make MatterConfig platform |
There was a problem hiding this comment.
Please create a ticket to follow up on this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Refactor WiFi initialization to remove platform-specific dependencies and unify initialization function
Testing
Manually build the RCP combinations for RS9116, RCP 917, RCP WF200 with EFR32MG24.
Tested commissioning flow with RCP 917, RCP WF200 with EFR32MG24.