Set up an kInternalDeviceAccess Auth mode to be used by internal requests when building subject descriptors
#37174
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
src/access/AccessControl.cpp
Outdated
| @@ -98,6 +98,8 @@ char GetAuthModeStringForLogging(AuthMode authMode) | |||
| { | |||
| case AuthMode::kNone: | |||
| return 'n'; | |||
| case AuthMode::kInternal: | |||
There was a problem hiding this comment.
I think there needs to be other checks elsewhere to grant Administer to kInternal
There was a problem hiding this comment.
I did a grep where kPASE nad kCASE was used and could not find any obvious places. This is one of my concerns: I am not actually really sure where these are needed or not. I believe IM does the validation, so by the time we get to DataModel providers we do not care anymore, so I think this is fine for the purpose of Provider access.
|
PR #37174: Size comparison from 04f1688 to 069f927 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
|
PR #37174: Size comparison from 04f1688 to 84816e1 Full report (71 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
changed the title
kInternal Auth mode to be used by internal requests when building subject descriptorskInternalDeviceAccess Auth mode to be used by internal requests when building subject descriptors
bzbarsky-apple
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow
SubjectDescriptorsettings to trickle down marked as internal requests rather than pretending PASE or CASE without a real remote node requesting interactions.Updated the PR-RPC implementation to use this flag for its reads/writes of attributes (this is on top of setting the kInternal flag for the read/write requests).
Testing
Letting CI to validate this, as the intent is "no regressions"