Fix broken catalog-build-from-index command #390
Conversation
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Bobbins228, sutaakar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -331,7 +331,7 @@ catalog-build-from-index: opm ## Build a catalog image. | |||
| mkdir catalog | |||
| $(OPM) render $(CATALOG_BASE_IMG) -o yaml > catalog/bundles.yaml | |||
| $(OPM) render $(BUNDLE_IMG) $(OPM_BUNDLE_OPT) > catalog/codeflare-operator-bundle.yaml | |||
| $(SED) -i -E "s/(.*)(- name: codeflare-operator.$(PREVIOUS_VERSION).*)/\1- name: codeflare-operator.$(VERSION)\n replaces: codeflare-operator.$(PREVIOUS_VERSION)\n\2/" catalog/bundles.yaml | |||
| $(SED) -i -E "s/(.*)(- name: codeflare-operator.v0.2.0)/\1- name: codeflare-operator.$(VERSION)\n replaces: codeflare-operator.$(PREVIOUS_VERSION)\n\2/" catalog/bundles.yaml | |||
There was a problem hiding this comment.
excuse my lack of sed knowledge here but are we now hardcoding a version? is this PR just for this fix?
There was a problem hiding this comment.
The purpose of this line is to inject replacing entry into the bundle section, where replacing entries are kept.
Originally this new replacing entry is placed right before last CodeFlare operator entry, however due to the regex issues with v1.0.0 the injection was duplicated. By fixing the searched text I made sure that only one injection is done.
Anyway this code is used just for tests, for real OLM release this bundle index is generated in OLM repo, we just provide manifests.
Issue link
What changes have been made
Verification steps
Checks