Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest makepad with new implicit redraw API #328

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kevinaboos
Copy link
Member

This builds and runs, but the performance is not great.

The biggest problem is that the inner RoomScreen content (within a Tab in the Dock) no longer refreshes itself when the user selects a room from the RoomsList.
If the user manually re-selects the tab it will refresh properly this happens both when selecting a new room and when closing a tab to reveal the prior room.

Another (smaller) problem is that the scrolling of the RoomsList is mucH slower and choppier than before.

This builds and runs, but the performance is not great.

The biggest problem is that the inner RoomScreen content
(within a Tab in the Dock) no longer refreshes itself
when the user selects a room from the RoomsList.
If the user manually re-selects the tab it will refresh properly
this happens both when selecting a new room and when closing
a tab to reveal the prior room.

Another (smaller) problem is that the scrolling of the RoomsList
is mucH slower and choppier than before.
@kevinaboos kevinaboos marked this pull request as draft January 19, 2025 01:27
joulei and others added 2 commits January 22, 2025 12:52
- Operations like tab creation and focus cannot be performed within draw_walk() as the draw flow now prevents from performing actions that would trigger a redraw, and the Dock internally performs and expects a redraw to be happening in order to draw the tab content.

These changes move those operations out of the draw_walk and into handle_action. This means we can't access the app_state directly so we are using the already existing RoomListAction::Selected action.
Do not manipulate dock tabs within the draw flow
@kevinaboos kevinaboos marked this pull request as ready for review January 23, 2025 08:07
@kevinaboos kevinaboos added waiting-on-author This issue is waiting on the original author for a response waiting-on-review This issue is waiting to be reviewed labels Jan 23, 2025
@kevinaboos kevinaboos changed the title Update to latest makepad with new implicit redraw API (WIP) Update to latest makepad with new implicit redraw API Jan 23, 2025
@kevinaboos kevinaboos self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author This issue is waiting on the original author for a response waiting-on-review This issue is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants