nodeFilter
: Add GossipBlobSidecarMessage
case.
#14822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Before this commit, this kind of logs were possible:
Note this bug has no real other impact than logging these errors: Since all nodes are subscribed to these subnets, as soon as some peers are found, there is no more issue.
Why not using
s.subscribe
instead ofs.subscribeWithParameters
?Blobs subnets were before considered as static subnets. But since Electra, the number of subnets is a function of the epoch. So it's better to use
s.subscribeWithParameters
than 2 specific but almost identic functions ins.subscribe
.Why
filterPeerForBlobSubnet
is the only one returning alwaystrue
?Because blobs subnets are actually the only subnets which are both dynamic AND which have to be subscribed by all the nodes. So,
filterPeerForBlobSubnet
does not filter out any node.Acknowledgements