Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mode for 'ec-ic' #308

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

KristjanESPERANTO
Copy link
Collaborator

@KristjanESPERANTO KristjanESPERANTO commented Dec 20, 2023

This will fix on error in the integration test.

The tap update was only suitable here, it has nothing to do with the fix.
Update: The tap update has been withdrawn.

This threw an error in the intigration test.
@derhuerst
Copy link
Member

The tap update was only suitable here, it has nothing to do with the fix.

The change from ^18.0.4 to ^18.6.1 doesn't have any effects since a) we're using a semver range here (^) and b) the lockfile isn't checked into Git.

If you had cloned hafas-client and installed dependencies (which creates a package-lock.json lockfile) before, and now want to get the latest tap version, run npm upgrade instead.

@@ -67,7 +67,7 @@ const products = [
},
{
id: 'ec-ic',
mode: 'ec-ic',
mode: 'train',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though ec-ic was not intended, this could be considered a breaking change by some people who depend on this specific value. I'm still fine with publishing with a non-major version though.

@KristjanESPERANTO KristjanESPERANTO changed the title Fix mode for 'ec-ic' + Update tap Fix mode for 'ec-ic' Jan 6, 2024
@KristjanESPERANTO
Copy link
Collaborator Author

Okay I've withdrawn the tap update.

@derhuerst derhuerst merged commit 8520eb3 into public-transport:main Jan 9, 2024
6 of 9 checks passed
@derhuerst
Copy link
Member

Thanks!

@KristjanESPERANTO KristjanESPERANTO deleted the tests branch January 10, 2024 18:32
@derhuerst
Copy link
Member

In case anyone is wondering: A while ago, I published this fix as [email protected]. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants