Introduce SpaceId and UserId #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleewho
commented
Jun 9, 2022
| fun PubNub.removeMemberships( | ||
| spaceId: SpaceId, | ||
| firstUserId: UserId, | ||
| vararg userIds: IUserId |
There was a problem hiding this comment.
I had to introduce an interface here to avoid the problem of value classes not yet being supported by varargs as stated here Kotlin/KEEP#104 (comment). When it's no longer an issue we can remove it. I would appreciate some help with naming that though :)
There was a problem hiding this comment.
For me current interface name is ok.
marcin-cebo
reviewed
Jun 9, 2022
| fun PubNub.removeMemberships( | ||
| spaceId: SpaceId, | ||
| firstUserId: UserId, | ||
| vararg userIds: IUserId |
There was a problem hiding this comment.
For me current interface name is ok.
pubnub-memberships/src/integrationTest/kotlin/com/pubnub/entities/MembershipIntegTest.kt
Outdated
Show resolved
Hide resolved
marcin-cebo
reviewed
Jun 10, 2022
pubnub-memberships/src/main/kotlin/com/pubnub/entities/models/consumer/membership/Membership.kt
Outdated
Show resolved
Hide resolved
pubnub-memberships/src/main/kotlin/com/pubnub/entities/models/consumer/membership/Membership.kt
Outdated
Show resolved
Hide resolved
Chesteer89
suggested changes
Jun 10, 2022
pubnub-memberships/src/main/kotlin/com/pubnub/entities/MembershipExtension.kt
Outdated
Show resolved
Hide resolved
pubnub-users/src/main/kotlin/com/pubnub/entities/models/consumer/user/User.kt
Outdated
Show resolved
Hide resolved
marcin-cebo
approved these changes
Jun 14, 2022
pubnub-memberships/src/main/kotlin/com/pubnub/entities/MembershipExtension.kt
Show resolved
Hide resolved
pubnub-memberships/src/main/kotlin/com/pubnub/entities/MembershipExtension.kt
Show resolved
Hide resolved
Chesteer89
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings some simplification to the naming of membership methods