Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare code for breaking change in Protobuf C++ API. #185

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Prepare code for breaking change in Protobuf C++ API. #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pybind11_protobuf/proto_cast_util.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ namespace {
// Resolves the class name of a descriptor via d->containing_type()
py::object ResolveDescriptor(py::object p, const Descriptor* d) {
return d->containing_type() ? ResolveDescriptor(p, d->containing_type())
.attr(py::str(d->name()))
: p.attr(py::str(d->name()));
.attr(py::str(std::string_view(d->name())))
: p.attr(py::str(std::string_view(d->name())));
}

// Returns true if an exception is an import error.
Expand Down
Loading