Added keyword arguments to remote.py

[hjkarssies]

Got the following error:
TypeError: ModbusClientMixin.read_holding_registers() takes 2 positional arguments but 3 positional arguments (and 1 keyword-only argument) were given

Fixed it by adding keywords to callbacks in __build_mapping(self)

[janiversen]

LGTM, thanks

[janiversen]

Ups seems you broke our test harness, please fix that.

[janiversen]

I was really too fast, address and count are positional not optional parameters.

[janiversen]

Are you using an older version of pymodbus but have the current examples, that would explain your problems, because earlier it accepted named parameters for positional parameters

[hjkarssies]

I have pymodbus 3.8.3 installed, and I'm not running any of the examples. The error arises when I make a Modbus TCP to RTU gateway like this:

async def modbus_gateway(self):
    store = RemoteSlaveContextWithFix(self.rtu_client, self.rtu_slave)
    context = ModbusServerContext(slaves=store, single=True)
    await StartAsyncTcpServer(context=context, address=("", self.tcp_port))

About breaking the test harness, I have no idea what went wrong and how I can fix it to be honest, but I would be happy to take a look if you can point me in the right direction!

[janiversen]

Well as you can see, the CI complains (correctly) because address= is not allowed. Since your fix works on your system it indicates the pymodbus is old.

Please be aware that the remote datastore offers very limited functionality and in essence do not work as expected. The main problem is that only a few requests are supported and no proper error handling.

We are working on a new version that interconnects the framers to give 100% functionality

The tests are as usual in the test directory, but as I wrote the real problem is that address= is not allowed in v3.8.3