feat(pulse): add provider #2279
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
| uint128 providerFeeInWei = _state.providers[provider].feeInWei; | ||
| uint256 gasFee = callbackGasLimit * providerFeeInWei; |
There was a problem hiding this comment.
as discussed, changed this to use provider fee to protect from future price jumps/drops
| // Check if enough gas remains for callback + events/cleanup | ||
| // We need extra gas beyond callbackGasLimit for: | ||
| // 1. Emitting success/failure events | ||
| // 2. Error handling in catch blocks | ||
| // 3. State cleanup operations | ||
| if (gasleft() < (req.callbackGasLimit * 3) / 2) { | ||
| revert InsufficientGas(); | ||
| } | ||
|
|
There was a problem hiding this comment.
removed this because if insufficient gas error occurs within callback then PriceUpdateCallbackFailed will be emitted with "low-level error (possibly out of gas)" and otherwise if insufficient gas for the executeCallback function itself, it will revert with out-of-gas
my understanding regarding to that is that we wanted to go with the if we decide to just go with the simple exclusivity option then yeah we can implement this now, i can add this in a following PR |
No description provided.