Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for int32_t indices in TBE training (2F/N) #3376

Closed
wants to merge 1 commit into from

Conversation

q10
Copy link
Contributor

@q10 q10 commented Nov 14, 2024

Summary: - Add index_t support to TBE training backward kernels

Differential Revision: D65938455

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for pytorch-fbgemm-docs ready!

Name Link
🔨 Latest commit 295280a
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-fbgemm-docs/deploys/67901a85f37882000852eef4
😎 Deploy Preview https://deploy-preview-3376--pytorch-fbgemm-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@q10 q10 force-pushed the export-D65938455 branch from 3c60554 to e93c1ec Compare November 14, 2024 19:38
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:

X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

@q10 q10 force-pushed the export-D65938455 branch from e93c1ec to 634dde0 Compare November 14, 2024 21:02
q10 added a commit to q10/FBGEMM that referenced this pull request Nov 14, 2024
Summary:

X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

@q10 q10 force-pushed the export-D65938455 branch 2 times, most recently from d711159 to 617052e Compare November 15, 2024 05:03
@q10 q10 force-pushed the export-D65938455 branch from 617052e to 81693e9 Compare December 14, 2024 22:30
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:

X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@q10 q10 force-pushed the export-D65938455 branch from 81693e9 to 7450c71 Compare December 14, 2024 22:30
q10 added a commit to q10/FBGEMM that referenced this pull request Dec 14, 2024
Summary:

X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

@facebook-github-bot
Copy link
Contributor

Hi @q10!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@q10 q10 force-pushed the export-D65938455 branch from 7450c71 to 8ca977c Compare January 2, 2025 20:38
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 2, 2025
Summary:

X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

@q10 q10 force-pushed the export-D65938455 branch from 8ca977c to 9fc1204 Compare January 3, 2025 01:59
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 3, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@q10 q10 force-pushed the export-D65938455 branch from 9fc1204 to abd3218 Compare January 6, 2025 21:42
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 6, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 14, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 15, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 16, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 17, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
@q10 q10 force-pushed the export-D65938455 branch from f411b18 to eef6c3b Compare January 21, 2025 22:06
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
@q10 q10 force-pushed the export-D65938455 branch from eef6c3b to 295280a Compare January 21, 2025 22:06
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D65938455

q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
q10 added a commit to q10/FBGEMM that referenced this pull request Jan 21, 2025
Summary:
X-link: facebookresearch/FBGEMM#623


X-link: facebookresearch/FBGEMM#467

- Add `index_t` support to TBE training backward kernels

Reviewed By: basilwong

Differential Revision: D65938455
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 79a75bf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants