Revert D65620886 #3582
Closed
Revert D65620886 #3582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 16, 2025
Summary: X-link: facebookresearch/FBGEMM#666 - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886 Reviewed By: leitian, jianyuh Differential Revision: D68291310
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 16, 2025
Summary: X-link: facebookresearch/FBGEMM#666 - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886 Reviewed By: leitian, jianyuh, yaoyj11 Differential Revision: D68291310
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 17, 2025
Summary: X-link: facebookresearch/FBGEMM#666 - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886 Reviewed By: leitian, jianyuh, yaoyj11 Differential Revision: D68291310
q10
added a commit
to q10/FBGEMM
that referenced
this pull request
Jan 17, 2025
Summary: X-link: facebookresearch/FBGEMM#666 - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886 Reviewed By: leitian, jianyuh, yaoyj11 Differential Revision: D68291310
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
Summary: X-link: facebookresearch/FBGEMM#666 - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886 Reviewed By: leitian, jianyuh, yaoyj11 Differential Revision: D68291310
|
This pull request was exported from Phabricator. Differential Revision: D68291310 |
|
This pull request has been merged in 87db593. |
avbokovoy
added a commit
to ROCm/FBGEMM
that referenced
this pull request
Jan 22, 2025
This reverts commit 87db593.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
Summary: X-link: facebookresearch/FBGEMM#681 This PR: 1) Brings back the optimization reverted in #3582 2) Fixes the bug in tailing loop Pull Request resolved: #3599 Reviewed By: yaoyj11 Differential Revision: D68503146 Pulled By: q10 fbshipit-source-id: e7b35f109d72877272dee45b4c113b2bc2fbef8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: - Per discussions in https://fb.workplace.com/groups/fbgemmusers/permalink/9362556053825092/, revert D65620886
Reviewed By: jianyuh
Differential Revision: D68291310