Fix initial selection of Classification attribute

qgis · Jan 23, 2025 · f33604b · f33604b
1 parent fd67cd1
commit f33604b
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/app/3d/qgs3dmapcanvaswidget.cpp b/src/app/3d/qgs3dmapcanvaswidget.cpp
@@ -258,7 +258,6 @@ Qgs3DMapCanvasWidget::Qgs3DMapCanvasWidget( const QString &name, bool isDocked )
   mMapToolMeasureLine = new Qgs3DMapToolMeasureLine( mCanvas );
 
   mMapToolPointCloudChangeAttribute = new Qgs3DMapToolPointCloudChangeAttribute( mCanvas );
-  onPointCloudChangeAttributeSettingsChanged();
 
   mLabelPendingJobs = new QLabel( this );
   mProgressPendingJobs = new QProgressBar( this );
@@ -446,8 +445,11 @@ void Qgs3DMapCanvasWidget::updateLayerRelatedActions( QgsMapLayer *layer )
 
     whileBlocking( mCboChangeAttribute )->addItem( attribute.name() );
   }
-  if ( mCboChangeAttribute->findText( previousAttribute ) != -1 )
-    mCboChangeAttribute->setCurrentText( previousAttribute );
+
+  int index = mCboChangeAttribute->findText( previousAttribute );
+  if ( index < 0 )
+    index = mCboChangeAttribute->findText( QStringLiteral( "Classification" ) );
+  mCboChangeAttribute->setCurrentIndex( std::max( index, 0 ) );
 
   enableEditingTools( pcLayer->isEditable() );
 }
@@ -923,7 +925,6 @@ void Qgs3DMapCanvasWidget::onPointCloudChangeAttributeSettingsChanged()
   }
 
   mMapToolPointCloudChangeAttribute->setAttribute( attributeName );
-  // TODO: validate values for attribute
   mMapToolPointCloudChangeAttribute->setNewValue( mSpinChangeAttributeValue->value() );
 }