-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[processing] Fix save vector features to file algorithm's handling of pre-existing files #54367
Conversation
@nirvn the [not selected] entry in the screenshot... is a leftover from previous design? It is not an option, right? |
@nirvn A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged. Please update the description (not the comments) with helpful description and screenshot to help the work from documentors. Thank you! |
This pull request has been tagged for the changelog.
You can edit the description. Format available for credits
Thank you! |
} | ||
|
||
QVariantMap outputs; | ||
outputs.insert( QStringLiteral( "OUTPUT" ), dest ); | ||
outputs.insert( QStringLiteral( "OUTPUT" ), destination ); | ||
outputs.insert( QStringLiteral( "FILE_PATH" ), filePath ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
outputs.insert( QStringLiteral( "FILE_PATH" ), filePath ); | |
outputs.insert( QStringLiteral( "FILE_PATH" ), finalFileName ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nyalldawson , addressed.
780f89e
to
bbad20b
Compare
@DelazJ , it was an "option" until just now. The "[Not selected]" item is automatically added as the first option of an optional enum parameter. That's a hard-coded QGIS processing behavior. That said, I've just made the enum non-optional after a discussion with Nyall. While we needed the enum parameter to be optional to avoid API breakage, other forthcoming changes in the way QGIS processing handles things will improve things on that front. |
@nirvn |
@nirvn Why have you chosen “overwrite file” as default behaviour ? |
@dlejay , to retain previously established behavior as the default one. |
Description
This PR harmonize handling of preexisting files by the save vector features to file algorithm by informing users of default action (file overwrite) and allow to switch to other action/behavior (keep file, overwrite layer, keep file and layer, etc.).
Fixes #54333 .