Only update changed 3D entities when editing point cloud attributes #60225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QgsChunkedEntity gets a capability to update an existing sub-entity for a node by loading the node again, creating a new 3D entity, and then discarding the old entity in favor of the new one. QgsPointCloudLayer gets a new signal - emitted whenever a particular node's attribute values get changed. These two are combined for point cloud layer's 3D chunked entity: whenever there are edits to the point cloud data, instead of doing big hard reload of the whole point cloud, we only update entities of the few nodes that were modified. This greatly improves the user experience of point cloud editing (no "flashing" of the 3D view while loading everything from scratch), and it improves how quickly the changes can be seen.
for more information, see https://pre-commit.ci
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QgsChunkedEntity gets a capability to update an existing sub-entity for a node by loading the node again, creating a new 3D entity, and then discarding the old entity in favor of the new one.
QgsPointCloudLayer gets a new signal - emitted whenever a particular node's attribute values get changed.
These two are combined for point cloud layer's 3D chunked entity: whenever there are edits to the point cloud data, instead of doing big hard reload of the whole point cloud, we only update entities of the few nodes that were modified. This greatly improves the user experience of point cloud editing (no "flashing" of the 3D view while loading everything from scratch), and it improves how quickly the changes can be seen.