3D views: use the correct resolution on high DPI displays! #60247
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowadays Qt gives us size in device independent pixels, and we were using those values for the textures as well - but that means on high DPI screens where device pixel ratio is 2, we were rendering in low resolution and then upscaling the textures. This should fix that, and intermediate textures use the correct size - the rendered output is much crispier, yay!
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nowadays Qt gives us size in device independent pixels, and we were using those values for the textures as well - but that means on high DPI screens where device pixel ratio is 2, we were rendering in low resolution and then upscaling the textures. This should fix that, and intermediate textures use the correct size - the rendered output is much crispier, yay!
One potential problem is that existing QGIS projects may start to look slightly different, because e.g. line width or point sizes are in pixels - so on a high DPI screen one may need to double those values to get similar looking scene. And yes, we should move towards using millimeters like in 2D maps to avoid these issues...
Some examples from my laptop below (device pixel ratio = 2). Notice the more detailed edge lines or finer details in the point cloud.