Skip to content

Commit

Permalink
Merge branch 'nc/merge_all_together' into nc/array_compression_with_n…
Browse files Browse the repository at this point in the history
…ested_collections
  • Loading branch information
nicola-cab committed Mar 21, 2024
2 parents 5a4a05a + 3a6280a commit 51a8480
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/realm/cluster.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1681,7 +1681,7 @@ ref_type Cluster::typed_write(ref_type ref, _impl::ArrayWriterBase& out, const T
if (i == 1 || i == 2) {
// this check is not fine grained.. we are compressing everything that fits into m_int and
// m_pair_int which means timestamps, doubles, floats and links alongside integers.
// TODO: build an array mixed and check the type
// TODO: find a solution for this, maybe build an array of mixed and check the type.
written_leaf.set_as_ref(
i, Array::write(rot.get_as_ref(), m_alloc, out, only_modified, compressible));
}
Expand Down Expand Up @@ -1710,6 +1710,7 @@ ref_type Cluster::typed_write(ref_type ref, _impl::ArrayWriterBase& out, const T
else {
REALM_ASSERT(false);
}
// can this be the solution to for the integers that are stored straigh into composite array??
written_cluster.set_as_ref(j, written_leaf.write(out, false, false, compressible));
written_leaf.destroy();
}
Expand Down

0 comments on commit 51a8480

Please sign in to comment.