Suppress tsan warnings related to stopping BaaSaaS from inside a sign…

…al handler
realm · Mar 28, 2024 · 7de0f03 · 7de0f03
1 parent a206f8a
commit 7de0f03
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/test/object-store/util/sync/baas_admin_api.cpp b/test/object-store/util/sync/baas_admin_api.cpp
@@ -610,7 +610,7 @@ class BaasaasLauncher : public Catch::EventListenerBase {
 
     void testRunEnded(Catch::TestRunStats const&) override
     {
-        if (auto& baasaas_holder = get_baasaas_holder(); baasaas_holder.has_value()) {
+        if (auto& baasaas_holder = get_baasaas_holder()) {
             baasaas_holder->stop();
         }
     }

diff --git a/test/tsan.suppress b/test/tsan.suppress
@@ -24,3 +24,8 @@ race:adjtime
 # on the sync thread for async open task, should be harmless to suppress,
 # but ultimately needs to be fixed: #7083
 race:uv_async_init
+
+# We try to shut down the remote BaaSaaS instance from inside a signal handler,
+# which invovles a bunch of memory allocations. This is a pretty unsafe thing
+# to do, but we want to avoid leaking server resources.
+signal:realm::Baasaas::stop