Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RCORE-2037: [bindgen] smaller fixes after 14.4.0 #7507

Merged
merged 2 commits into from
Mar 22, 2024
Merged

RCORE-2037: [bindgen] smaller fixes after 14.4.0 #7507

merged 2 commits into from
Mar 22, 2024

Conversation

kneth
Copy link
Contributor

@kneth kneth commented Mar 21, 2024 •
edited
Loading

What, How & Why?

  • Add std::chrono::milliseconds as primitive type.
  • Update return value of SyncSession::full_realm_url.

Closes #7506

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kneth kneth requested a review from michael-wb March 21, 2024 17:31
@cla-bot cla-bot bot added the cla: yes label Mar 21, 2024
@kneth kneth requested a review from jedelbo March 21, 2024 17:31
michael-wb
michael-wb approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@michael-wb michael-wb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - sorry for missing these changes

@coveralls-official Coveralls Official
Copy link

Pull Request Test Coverage Report for Build kenneth.geisshirt_8

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 76 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-0.001%) to 91.823%
Files with Coverage Reduction New Missed Lines %
test/test_index_string.cpp 1 94.63%
src/realm/collection_parent.cpp 2 92.48%
src/realm/sync/noinst/server/server.cpp 2 76.84%
src/realm/util/file.cpp 2 81.02%
src/realm/uuid.cpp 2 97.01%
src/realm/table.cpp 3 90.81%
src/realm/util/future.hpp 3 95.98%
test/test_thread.cpp 3 66.67%
src/realm/sync/network/http.hpp 4 83.33%
src/realm/alloc_slab.cpp 5 92.93%
Totals Coverage Status
Change from base Build 2156: -0.001%
Covered Lines: 243121
Relevant Lines: 264771
💛 - Coveralls

@kneth kneth marked this pull request as draft March 22, 2024 07:15
@kneth kneth marked this pull request as ready for review March 22, 2024 08:02
@jedelbo jedelbo merged commit 3144148 into master Mar 22, 2024
8 of 10 checks passed
@jedelbo jedelbo deleted the kneth/bindgen/smaller-fixes branch March 22, 2024 10:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2024
@kneth kneth removed their assignment Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michael-wb michael-wb michael-wb approved these changes

@jedelbo jedelbo jedelbo approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Small updates to bindgen after 14.4.0
3 participants
@kneth @jedelbo @michael-wb