RCORE-2012 Report sync progress for upload download separately #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Precompute it for existing parameters for initial crud behaviour * Adjust existing tests * Add needed spec definitions
…ate field * Refactor to forward parsed parameters from download message to session as is
updates on download during bootstrap
"Feature/bugfix release"
…ad message received
reset to 0 from 1 after batch sync or when new data is added during active sync
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What, How & Why?
Change the callback in sync implementation for progress to report download/upload progress separately only when it really changes to match object-store user facing api
Fixes #7451
☑️ ToDos
bindgen/spec.yml, if public C++ API changed