Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made set_default_logger nullable in spec.yml #7515

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

kraenhansen
Copy link
Member

@kraenhansen kraenhansen commented Mar 22, 2024

What, How & Why?

Made set_default_logger nullable in spec.yml to allow the SDK to remove the default logger entirely.

☑️ ToDos

  • 📝 Changelog update
  • 🚦 Tests (or not relevant)
  • C-API, if public C++ API changed
  • bindgen/spec.yml, if public C++ API changed

@kraenhansen kraenhansen requested review from jedelbo and kneth March 22, 2024 14:51
@kraenhansen kraenhansen self-assigned this Mar 22, 2024
@cla-bot cla-bot bot added the cla: yes label Mar 22, 2024
@kraenhansen kraenhansen added no-jira-ticket Skip checking the PR title for Jira reference and removed cla: yes labels Mar 22, 2024
Copy link

coveralls-official bot commented Mar 22, 2024

Pull Request Test Coverage Report for Build kraen.hansen_55

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 556 unchanged lines in 26 files lost coverage.
  • Overall coverage decreased (-0.01%) to 91.819%

Files with Coverage Reduction New Missed Lines %
src/realm/array_key.cpp 1 98.61%
src/realm/index_string.hpp 1 93.68%
src/realm/sync/client.hpp 1 97.67%
test/fuzz_tester.hpp 1 59.58%
src/realm/collection_parent.cpp 2 92.48%
src/realm/query_engine.hpp 2 93.73%
src/realm/sync/network/http.hpp 2 82.41%
test/test_lang_bind_helper.cpp 2 94.24%
src/realm/object-store/sync/sync_session.hpp 3 93.75%
src/realm/table.cpp 3 90.81%
Totals Coverage Status
Change from base Build 2165: -0.01%
Covered Lines: 243111
Relevant Lines: 264772

💛 - Coveralls

@kraenhansen kraenhansen force-pushed the kh/reset-default-logger branch from 63b253d to caab2d0 Compare March 22, 2024 19:31
@cla-bot cla-bot bot added the cla: yes label Mar 22, 2024
@kraenhansen kraenhansen force-pushed the kh/reset-default-logger branch from caab2d0 to cd53bc8 Compare March 23, 2024 10:12
@kraenhansen kraenhansen changed the title Exposed a helper to reset_default_logger Made set_default_logger nullable in spec.yml Mar 23, 2024
@kraenhansen kraenhansen merged commit 0fcbf94 into master Mar 26, 2024
21 of 24 checks passed
@kraenhansen kraenhansen deleted the kh/reset-default-logger branch March 26, 2024 13:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes no-jira-ticket Skip checking the PR title for Jira reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants