Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update next major #7520

Closed
wants to merge 40 commits into from
Closed

update next major #7520

wants to merge 40 commits into from

Conversation

nicola-cab
Copy link
Member

@nicola-cab nicola-cab commented Mar 25, 2024

What, How & Why?

Start to preparing the ground for releasing integer arrays compression. Updating next-major to top of master.

jedelbo and others added 30 commits March 8, 2024 12:53
* Update the merge nested rules to handle sentinel instructions on conflicting data types

* Allow syncing nested collections and collections in mixed

* Add integration tests with the legacy sync server

* Do not expose set_collection on a dictionary

* Fix OT rule for add_int on Mixed fields

* Small fixes

* Fix linting errors

* Apply Clear instructions received from the server on nested collections

* Add OT rule Clear vs Update

* Reduce boilerplate in collections in mixed unit test (#7421)

* Document unit-tests

* Changes after code review

* Fix test comments & update changelog

---------

Co-authored-by: Jonathan Reams <[email protected]>
…iqueFunction (#7467)

This makes it trivially destructible and so eliminates a spurious crash related
to reading the variable on one thread while it's being destroyed on another
(due to the application exiting). This breaks the C API for registering a
custom default scheduler, but that turns out to be unused and so it can be
deleted. All users of the C++ scheduler API work with just a function pointer.
We only need the very next path element, not the entire remaining path.
…cated code

m_run_time_point was read on the target thread while being written on the
worker thread without any locking involved.
Giving Obj a virtual base class turns out to have a meaningful performance
impact.
Make Obj trivial and add a separate ObjCollectionParent type
…#7441)

* Added resumption delay configuration values to SyncClientTimeouts

* Added proper defaults to new reconnect values

* delay_jitter_divisor is no longer configurable

* Changed timer debug info to a warn
…ction (#7470)

The parent of a nested collection will always be up to date after making a
modification to the collection as we update it prior to performing the
modification and the modification cannot make the parent stale. Failing to
update the parent's content version meant that the parent was always considered
stale after an update to a child collection, resulting in the child getting
updated between each modification even when the modifications were all done via
a single accessor.
… size (#7492)

For encrypted files we always write data in page sized increments, so using a
buffer smaller than the page size results in writing the same page multiple
times. On arm64 Apple platforms, this was a problem for files between 16 KB and
4 MB.
…el hierarchy (#7494)

* Propagate category

* Add test cases

* Update changelog

* Setting log callback should not require log level

* Fix tests

* Update CHANGELOG

* Move changelog to breaking changes

* Code formatting

---------

Co-authored-by: Clemente <[email protected]>
Co-authored-by: Jørgen Edelbo <[email protected]>
…tal error and session does not retry connection (#7469)

* Moved to using a pre-initialized sync-route instead of leaving empty and querying on first connect attempt

* Added base url update logic when session connection fails - added verified flag to prevent updating location too much

* Updated changelog; added default_base_url for C_API; added restart_sessions param to set_sync_route()

* Fixed c_api compile error

* Silly uninitialized variable

* Updates from review; fixed deadlock in test

* Updated test

* Changed default base url to function in CAPI

* Updates from review

* Removed old test and updated translationg comments in create_ws_host_url

* Updates from review

* Updated changelog after release buidl

* Updates from review

* Moved HookedSocketProvider and HookedTransport to sync_test_utils for common use

* Added test for updating the an invalid sync route using local server

* Expanded test to use multiple realms with and without multiplexing

* Delete directory _after_ stopping app...

* Updates from review

* Updated comment and changelog from review
finnschiermer and others added 10 commits March 21, 2024 14:11
* threadsafe realm for init subscription callback

* changelog
* [bindgen] add std::chrono::milliseconds as primitive type. Update return value of SyncSession::full_realm_url.
* use proper C++ name
…ication (#7124)

* Add new field 'progress_estimate'
* Add parsing support to protocol codec for repurposed progress estimate field
* Refactor to forward parsed parameters from download message to session as is
* Add object-store based test for progress notifications
* Remove noop progress invocation in object-store api and simplify internals
* Pass through progress estimate from client impl to notifier and call updates on download during bootstrap
* Calculate client-side progress from the start of the upload/download
@nicola-cab nicola-cab requested a review from jedelbo March 25, 2024 14:06
@cla-bot cla-bot bot added the cla: yes label Mar 25, 2024
@nicola-cab nicola-cab closed this Mar 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants