-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(supabase): fixed 'in'-filter when used inside 'or' #6652
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 94e82ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, added a comment about nock records.
@@ -2073,3 +2073,77 @@ nock("https://iwdfzvfqbtokqetmbmbp.supabase.co:443", { | |||
'h3=":443"; ma=86400', | |||
], | |||
); | |||
|
|||
nock("https://iwdfzvfqbtokqetmbmbp.supabase.co:443", { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's please record the actualy request. Here we are providing the mock data, without making the request, and we are testing it based on the data provided by us. It's not really testing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, already thought so... is there a reason why the other tests also don't make actual requests or am i reading something wrong?
nevertheless will change to a real request
If a
in
Filter is used inside aLogicalFilter
it is not parsed correctly to supabase. See #6651PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
Filter get parsed incorrectly
or=(id.in.1,2,4)
What is the new behavior?
Filter get parsed correctly
or=(id.in.("1", "2"))
fixes (#6651)
Notes for reviewers